-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting my 3.x PRs to master #6483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
from
August 22, 2020 14:47
726e792
to
8f30a46
Compare
8 PRs with an average of 7 lines of changes! ;-) |
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
5 times, most recently
from
August 23, 2020 07:22
3c51510
to
46b95bc
Compare
Jojo-Schmitz
changed the title
[WIP] Porting 3.x PRs to master
Porting my 3.x PRs to master
Aug 23, 2020
29 tasks
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
4 times, most recently
from
August 31, 2020 13:29
7418554
to
8fe8761
Compare
Will rebase it to resolve merge conflicts, that'll loose the commits that have been merged already. |
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
2 times, most recently
from
September 2, 2020 15:27
d2cbee8
to
9dc1c4c
Compare
BTW: I'm not opposing any of these fixes being merged to master before merging them into 3.x ;-) |
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
from
September 2, 2020 17:47
a6c9d70
to
c2b8620
Compare
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
from
September 28, 2020 07:40
c2b8620
to
742b7d5
Compare
Merged
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
6 times, most recently
from
October 5, 2020 17:00
dec9672
to
0bf214c
Compare
Jojo-Schmitz
commented
Oct 6, 2020
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
from
October 7, 2020 08:29
0bf214c
to
1a68c8f
Compare
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
2 times, most recently
from
October 13, 2020 14:17
56e5424
to
7f5e04b
Compare
simplify CMAkeListe.txt for tours and save some space by not installing any *_en.qm files
* Clarify the "don't ask again" * Mention the current MuseScore version (that way the same dialog still works in MuseScore 4) * Don't mark the score dirty if the reset is taken
and use Steinberg's naming to easy further updates
but not for Windows, due to a problem with WIX, see musescore@daa5fb7#comments
Adding mnemonics for Save, Save As… and Resource Manager…, Print…, Parts… and Export… See https://musescore.org/en/node/309973
not just as '.mid'
and in the same way as it is done in PianoLevels::updateNotes()and NoteTweakerDialog::updateNotes()
Jojo-Schmitz
force-pushed
the
3.x-to-master
branch
from
October 19, 2020 09:14
7f5e04b
to
1debe37
Compare
Merged
Jojo-Schmitz
referenced
this pull request
in cbjeukendrup/MuseScore
Aug 30, 2021
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 8, 2022
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far including my PRs (in numerical order), some not yet merged into 3.x:
PianoView::updateNotes()
#6667 - fix #311661: Fix potential crash inPianoView::updateNotes()
(merged into 3.x)PR could get merged as a whole (if and when all their counterparts pass muster and got merged into 3.x), or the individual commits can get
git cherry-pick
ed as needed. In the latter case please tick them in the above list.See also: