convert as many "enum" as possible to "enum class", and make them ": char" in the due course #4 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not change enum Tpc, its not a real enum. |
|
Glad to hear that ;-) |
|
This should conclude the series of changes to enums in libmscore, so this might be the time to merge. |
more work needed to make it an enum class
and change to a better sentinel for end of list. Also move the Q_DECLARE_METATYPE(Ms::ValueType) nearer to its definition. This should conclude the work on the enums in libmsore/mscore.h.
and make enum LayoutFlag a ": char" (making it an enum class requires more work, as it is used for flags)
but an attempt to get rid of the FILE_ prefix failed miserably whith some bizarre compiler error message.
and to be able to ret rid of the KEY_ prefix, change enum Tpc's members by adding (back) the prefix TPC_
more work needed in midi/midiinstrument.{h,cpp}?
as it is used for flags, turning into an enum would require much more work
and adjust entire file to MuseScore coding style
lasconic
added a commit
that referenced
this pull request
May 30, 2014
convert as many "enum" as possible to "enum class", and make them ": char" in the due course #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of PR #914, #927 and #935
Several enum types are "enum class" (i.e. typesafe C++ enums), several others are not.
Also making them ": char" should reduce the size of these structures.
Help in converting "enum AlignmentFlags", "enum ArticulationShowIn", "enum ElementFlag", "enum Hidden", "enum LayoutFlag", "enum Repeat" and "enum SegmentType" into an "enum class" needed, these are used as flags.
Also some help is needed to convert "enum TextStyleType" into an "enum class", but for different reasons (read: complexity).