convert as many "enum" as possible to "enum class", and make them ": char" in the due course #6 #1005
Conversation
|
@wschweer : was it SymId that should get changed from short back to int or SegmentType? Or both? |
|
I would do both. Any reason why SegmentType couldn't get the same treatment? |
|
No real reason, I just though it had been SymId only, then I realized that in the last PR it was SegmentType. |
|
Where to move Direction and DirectionH? They are used for the plugin framework in class Note. Move them there? Or is there some better place (class MScore?) or better method? Direction is also used (for the plugin framework) in class SlurTie. |
|
Direction and DirectionH should be in class MScore. |
|
OK. Can't we combine them into one? Or rename Direction to DirectionV to make the difference more obvious? |
needed to make it available to the Plugin framework
the memory saved is not worth the performance penalty
needed to make it available to the Plugin framework
needed to make it available to the Plugin framework
needed to make it available to the plugin framework and the memory saved is not worth the performance penalty
and register Hairpin::Type, FiguredBassItem::ContLine and Lyrics::Syllabic, which seemd missing. Also fix registration of Element::Type and Segment::Type to what they had been before.
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
needed to make it available to the plugin framework
and expose it to the plugin framwork, read-only for now, as we don't (yet?) have an undo method for it
needed to make them available to the plugin framework
convert as many "enum" as possible to "enum class", and make them ": char" in the due course #6
Follow up of PR #914, #927, #935, #936 and #946
Several enum types are "enum class" (i.e. typesafe C++ enums), several others are not.
Also making them ": char" should reduce the size of structures using them.
Some (at least those used in Q_ENUMS()) need to get moved inside a class, in order to be available to the plugin framework.
And simplify some ot the enum names to not have the class names as part of the enum Name.