Added Comments #340
Merged
Added Comments #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1057
💛 - Coveralls |
afeena
reviewed
Jul 18, 2019
tanner/emulators/xxe_injection.py
Outdated
| """ | ||
| Handler of emulator | ||
| :param attack_params (list): contains dicts as elements with id and value (payload from attacker) as keys | ||
| :return: dict: value (result of emulator), page (if set to true the payload will be injected to index.html |
There was a problem hiding this comment.
(dict)
for consistency with your style of naming types :)
afeena
reviewed
Jul 18, 2019
| """ | ||
| Handler of emulator | ||
| :param attack_params (list): contains dicts as elements with id and value (payload from attacker) as keys | ||
| :return: dict: value (result of emulator), page (if set to true the payload will be injected to index.html |
afeena
reviewed
Jul 18, 2019
tanner/utils/mysql_db_helper.py
Outdated
| """ | ||
| Checks if DB exists or not | ||
| :param db_name (str): mysql db name | ||
| :return: result (integer): 0 if no such database exists else 1 |
afeena
reviewed
Jul 18, 2019
tanner/utils/mysql_db_helper.py
Outdated
| @@ -58,6 +68,11 @@ def __init__(self): | |||
| conn.close() | |||
|
|
|||
| async def delete_db(self, db): | |||
| """ | |||
| Deletes the database | |||
| :param db: db name to be deleted | |||
afeena
reviewed
Jul 18, 2019
| """ | ||
| Injects the code from attacker to vulnerable code and get emulation results from php sandbox. | ||
| :param code (str): Input payload from attacker | ||
| :return: object_injection_result (dict): Keys - file_md5 (md5 hash), stdout (injection result) |
There was a problem hiding this comment.
please choose one style for describing keys of the dict or do not name them at all
afeena
reviewed
Jul 18, 2019
tanner/utils/mysql_db_helper.py
Outdated
| Creates a aiomysql connection | ||
| :return: connection object | ||
| """ | ||
|
|
||
| conn = await aiomysql.connect(host=TannerConfig.get('SQLI', 'host'), | ||
| user=TannerConfig.get('SQLI', 'user'), | ||
| password=TannerConfig.get('SQLI', 'password') | ||
| ) | ||
| return conn | ||
|
|
||
| async def check_db_exists(self, db_name, ): |
There was a problem hiding this comment.
could you please remove additional comma in function parameters? :) I don't know why it is here :D
There was a problem hiding this comment.
Maybe its mainly for multiline code?
#315 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.