-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Comments #340
Added Comments #340
Conversation
Pull Request Test Coverage Report for Build 1057
💛 - Coveralls |
tanner/emulators/xxe_injection.py
Outdated
""" | ||
Handler of emulator | ||
:param attack_params (list): contains dicts as elements with id and value (payload from attacker) as keys | ||
:return: dict: value (result of emulator), page (if set to true the payload will be injected to index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(dict)
for consistency with your style of naming types :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😅
""" | ||
Handler of emulator | ||
:param attack_params (list): contains dicts as elements with id and value (payload from attacker) as keys | ||
:return: dict: value (result of emulator), page (if set to true the payload will be injected to index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(dict)
tanner/utils/mysql_db_helper.py
Outdated
""" | ||
Checks if DB exists or not | ||
:param db_name (str): mysql db name | ||
:return: result (integer): 0 if no such database exists else 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(int)
tanner/utils/mysql_db_helper.py
Outdated
@@ -58,6 +68,11 @@ def __init__(self): | |||
conn.close() | |||
|
|||
async def delete_db(self, db): | |||
""" | |||
Deletes the database | |||
:param db: db name to be deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type?
""" | ||
Injects the code from attacker to vulnerable code and get emulation results from php sandbox. | ||
:param code (str): Input payload from attacker | ||
:return: object_injection_result (dict): Keys - file_md5 (md5 hash), stdout (injection result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please choose one style for describing keys of the dict or do not name them at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
tanner/utils/mysql_db_helper.py
Outdated
Creates a aiomysql connection | ||
:return: connection object | ||
""" | ||
|
||
conn = await aiomysql.connect(host=TannerConfig.get('SQLI', 'host'), | ||
user=TannerConfig.get('SQLI', 'user'), | ||
password=TannerConfig.get('SQLI', 'password') | ||
) | ||
return conn | ||
|
||
async def check_db_exists(self, db_name, ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please remove additional comma in function parameters? :) I don't know why it is here :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe its mainly for multiline code?
#315 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it's a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
No description provided.