Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow insecure connection for RFI #364

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Allow insecure connection for RFI #364

merged 2 commits into from
Mar 6, 2020

Conversation

afeena
Copy link
Collaborator

@afeena afeena commented Mar 4, 2020

Fix #251

@t3chn0m4g3 Please check. I don't have any other ideas except allowing insecure connections. If you have better suggestions, I am completely open :)

@coveralls
Copy link

coveralls commented Mar 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1191

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 76.372%
Totals Coverage Status
Change from base Build 1190: 0.04%
Covered Lines: 1406
Relevant Lines: 1841
💛 - Coveralls

@t3chn0m4g3
Copy link
Contributor

Thank you, on it :)

@t3chn0m4g3 t3chn0m4g3 mentioned this pull request Mar 5, 2020
Closed
@t3chn0m4g3
Copy link
Contributor

t3chn0m4g3 commented Mar 5, 2020 •
edited
Loading

Works perfectly fine now. Thank you. Stumbled upon a strange behaviour though #367.

Update: Resolved, see closed #367

@t3chn0m4g3 t3chn0m4g3 mentioned this pull request Mar 5, 2020
Merged
@afeena
Copy link
Collaborator Author

afeena commented Mar 6, 2020

@t3chn0m4g3 thanks for testing!

@afeena afeena merged commit 51cb033 into mushorg:master Mar 6, 2020
@afeena afeena deleted the rfi-ssl branch March 6, 2020 20:53
afeena pushed a commit that referenced this pull request Mar 9, 2020
@t3chn0m4g3
Accomodate for PR #364 (#368)
9873047 
* Accomodate for PR #364

Needs #364 as parent
Turning Insecure on

* update naming

* Build without dist, causes error for phpox

* Remove faulty dist, use the one from upstream master

* Remove dist from Dockerfile ...

... cleanup after removing the build deps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificate error when loading RFI from remote site
3 participants
@afeena @coveralls @t3chn0m4g3