Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate for PR #364 #368

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Accomodate for PR #364 #368

merged 5 commits into from
Mar 9, 2020

Conversation

t3chn0m4g3
Copy link
Contributor

Needs #364 as parent
Turning Insecure on

Needs #364 as parent
Turning Insecure on
@coveralls
Copy link

coveralls commented Mar 5, 2020

Pull Request Test Coverage Report for Build 1203

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 76.372%

Files with Coverage Reduction New Missed Lines %
tanner/config.py 5 53.49%
tanner/emulators/base.py 5 94.44%
tanner/emulators/rfi.py 8 88.1%
Totals Coverage Status
Change from base Build 1190: 0.04%
Covered Lines: 1406
Relevant Lines: 1841

💛 - Coveralls

@t3chn0m4g3
Copy link
Contributor Author

Please test :)

@afeena
Copy link
Collaborator

afeena commented Mar 6, 2020

@t3chn0m4g3 thanks again for taking care of Docker :)

@afeena
Copy link
Collaborator

afeena commented Mar 6, 2020

@t3chn0m4g3 while building, got an error
ERROR: Service 'tanner_phpox' failed to build: ADD failed: stat /var/lib/docker/tmp/docker-builder811824814/dist: no such file or directory

Guess because of this line

ADD dist/ /root/dist/

@t3chn0m4g3
Copy link
Contributor Author

You are correct. I admit, it was late :)

... cleanup after removing the build deps.
@t3chn0m4g3
Copy link
Contributor Author

@afeena This should work now 🤞

@afeena afeena merged commit 9873047 into mushorg:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants