Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persian accidental values #1007

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Add persian accidental values #1007

merged 1 commit into from
Oct 2, 2022
+14 −0

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Oct 2, 2022

The values (koron and sori) were requested in #680. Closes #680

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 2, 2022
rettinghaus
rettinghaus approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@musicEnfanthen musicEnfanthen merged commit 950eb9b into music-encoding:develop Oct 2, 2022
@lpugin lpugin mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahankinson ahankinson ahankinson approved these changes

@rettinghaus rettinghaus rettinghaus approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iranian quarter tones (Koron and Sori)
4 participants
@lpugin @ahankinson @rettinghaus @musicEnfanthen