Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also add data.ACCIDENTAL.persian to data.ACCIDENTAL.WRITTEN #1026

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Also add data.ACCIDENTAL.persian to data.ACCIDENTAL.WRITTEN #1026

merged 1 commit into from
Oct 4, 2022

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Oct 4, 2022

This was overlooked in the #1007 PR

@lpugin lpugin marked this pull request as ready for review October 4, 2022 11:57
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 4, 2022
kepper
kepper approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, many thanks, @lpugin

@lpugin lpugin requested review from musicEnfanthen and removed request for musicEnfanthen October 4, 2022 18:33
@musicEnfanthen musicEnfanthen changed the title Also add data.ACCITENTAL.persian to data.ACCITENDAL.WRITTEN Also add data.ACCIDENTAL.persian to data.ACCIDENTAL.WRITTEN Oct 4, 2022
@musicEnfanthen musicEnfanthen merged commit 8443a76 into music-encoding:develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kepper kepper kepper approved these changes

@rettinghaus rettinghaus rettinghaus approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lpugin @kepper @rettinghaus @musicEnfanthen