-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust paths for pdf guidelines generation #1009
Merged
kepper
merged 38 commits into
music-encoding:pdf-guidelines-test
from
musicEnfanthen:pdf-guidelines-test
Oct 2, 2022
Merged
Adjust paths for pdf guidelines generation #1009
kepper
merged 38 commits into
music-encoding:pdf-guidelines-test
from
musicEnfanthen:pdf-guidelines-test
Oct 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unclarity in units, allows more units relying on existing datatype definitions, introduces three additional units derived from CSS
Create att.tuning class
make stem.vis part of att.extSym and att.visibility
…ayer Change macro name of data.OTHERSTAFF
Make custos part of att.visualOffset.ho
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@enote.com>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
More clarity in typography and measurement units
fixes music-encoding#999. It allows to have attributes referencing a choice of multiple other datatypes.
…ype-guidelines Fix broken build due to failing datatype recognition
…to pdf-guidelines-test
github-actions
bot
added
Component: Build
changes to build.xml (assigned automatically)
Component: Core Schema
changes to source/modules/* (assigned automatically)
Component: Customizations
changes to customizations/**/* (assigned automatically)
Component: Utils
changes to utils/**/* (assigned automatically)
labels
Oct 2, 2022
kepper
approved these changes
Oct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making this such a legible and easy to check PR, @musicEnfanthen ;-) 👍. Looked it up on your machine, all seems good…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Build
changes to build.xml (assigned automatically)
Component: Core Schema
changes to source/modules/* (assigned automatically)
Component: Customizations
changes to customizations/**/* (assigned automatically)
Component: Utils
changes to utils/**/* (assigned automatically)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the paths for the web pdf guidelines in this commit 9472429
All other changes are updating the pdf-guidelines-test branch to the latest changes from develop.