Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce docu, Gl 3.7: condition, colophon #1089

Merged

Conversation

riedde
Copy link
Contributor

@riedde riedde commented Mar 18, 2023

This PR is a proposal by @music-encoding/ig-metadata
The authors of the texts are referenced by the Co-authored-by keyword.

Please note: This PR is going to be merged into the branch ig-metadata!

Reviews and constructive suggestions are welcome!

riedde and others added 4 commits March 3, 2023 08:40
Co-authored-by @music-encoding/ig-metadata
Co-authored-by @music-encoding/ig-metadata
# Conflicts:
#	source/docs/03-metadata.xml
Co-authored-by: Mark Saccomano <mss2221@columbia.edu>
@github-actions github-actions bot added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label Mar 18, 2023
riedde and others added 2 commits March 20, 2023 07:47
Thanks!

Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
@musicEnfanthen
Copy link
Member

@riedde is this ready for re-review? (Maybe you can indicate that for other open GI 3.7 PRs as well?)

@riedde
Copy link
Contributor Author

riedde commented Jun 5, 2023

@riedde is this ready for re-review? (Maybe you can indicate that for other open GI 3.7 PRs as well?)

@musicEnfanthen Yes, it is. Sorry for being inactive for so long!

source/docs/03-metadata.xml Outdated Show resolved Hide resolved
source/docs/03-metadata.xml Outdated Show resolved Hide resolved
source/docs/03-metadata.xml Outdated Show resolved Hide resolved
@musicEnfanthen
Copy link
Member

Thanks @riedde, added some minor comments/suggestions.

Copy link
Member

@ahankinson ahankinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few minor wording suggestions! Thank you.

@bwbohl bwbohl added this to the MEI 5.0 milestone Jun 16, 2023
bwbohl and others added 4 commits June 16, 2023 09:20
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Benjamin W. Bohl <b.w.bohl@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
@musicEnfanthen musicEnfanthen merged commit bd0c38f into music-encoding:ig-metadata Jun 16, 2023
1 check passed
@riedde riedde deleted the gl-3.7/conditionColophon branch January 20, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants