guidelines: move changes from ig-metadata branch into develop for MEI v5.0 #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: @ahankinson Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
…e/music-encoding into restructure-guidelines-3.7
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
…e/music-encoding into restructure-guidelines-3.7 # Conflicts: # source/docs/03-metadata.xml
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
…e/music-encoding into restructure-guidelines-3.7
# Conflicts: # source/docs/03-metadata.xml # source/examples/header/header-sample094.txt
guidelines: introduce docu, Gl 3.7: physical properties
ahankinson
requested changes
Jul 4, 2023
|
Looks great! Thank you. |
bwbohl
requested changes
Jul 4, 2023
bwbohl
reviewed
Jul 4, 2023
|
after ignoring the above two there's still a parsing error reported by the build and a missing element definition: ERROR: Unable to parse the following XML snippet, which is apparently not well-formed: |
Co-authored-by: Andrew Hankinson <andrew.hankinson@rism.digital>
bwbohl
reviewed
Jul 7, 2023
Co-authored-by: Benjamin W. Bohl <bohl@em.uni-frankfurt.de>
it seems this was unintentionally deleted
|
@ahankinson Can I ask you to resolve the "requested changes" if they are resolved? |
musicEnfanthen
approved these changes
Jul 7, 2023
ahankinson
approved these changes
Jul 10, 2023
bwbohl
approved these changes
Jul 10, 2023
|
@riedde Can you please double-check in the live guidelines if everything is as expected? |
|
Checked one time, looks great! Will check again tomorrow.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs, must be merged before merging this PR!