Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: resolve att def duplications #1157

Merged
merged 18 commits into from
Jul 10, 2023
Merged

Conversation

kepper
Copy link
Member

@kepper kepper commented May 26, 2023

There are more than 100 attributes sharing their names with other attDefs. Most of them are perfectly sensible, because they are used in different contexts, and have quite different models – they just share their names, which are perfectly appropriate in their context. Sometimes, however, <attDef>s have just been copied over to not interfere with the class system. These cases are maintenance issues, which this PR tries to resolve. None of these changes should affect MEI instances.

@kepper kepper added this to the MEI 5.0.0 milestone May 26, 2023
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label May 26, 2023
@kepper kepper marked this pull request as draft May 26, 2023 14:23
@kepper kepper marked this pull request as ready for review May 26, 2023 15:19
@rettinghaus rettinghaus requested a review from a team May 26, 2023 16:01
@rettinghaus
Copy link
Member

This is super, thanks. Please give me the time to have a proper look at this.

musicEnfanthen
musicEnfanthen previously approved these changes May 26, 2023
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kepper for this consolidation work.

@kepper
Copy link
Member Author

kepper commented May 26, 2023

Just for reference: I had another look at mensural stems, and I believe it's best to leave the situation as it is for now. We can revise as soon as we have the discussion around #1159 (which I'll push to someday…)

Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the work! Some ideas for improvements.

source/modules/MEI.gestural.xml Show resolved Hide resolved
source/modules/MEI.cmn.xml Show resolved Hide resolved
source/modules/MEI.shared.xml Show resolved Hide resolved
@rettinghaus
Copy link
Member

Also I'm a bit hesitant to extract att.coordinated.ul. Why is att.coordinated inappropriate there?

@musicEnfanthen
Copy link
Member

@kepper Would you have time to address conflicts and comments?

@musicEnfanthen musicEnfanthen changed the title Resolve att def duplications schema: resolve att def duplications Jun 16, 2023
@bwbohl
Copy link
Member

bwbohl commented Jun 20, 2023

ping @kepper

@kepper
Copy link
Member Author

kepper commented Jun 22, 2023

Also I'm a bit hesitant to extract att.coordinated.ul. Why is att.coordinated inappropriate there?

<graphic> has it's own @ulx and @uly definitions, which seems inappropriate. As I didn't want to change the footprint of the the schema, using att.coordinated on <graphic> would be incorrect, so separating out the upper left coordinates in a class of their own seems to be the better way. Of course it is also possible to discuss whether <graphic> should use other attributes, but that seems like a bigger change than what we have so far. Also, it seems like combining the new att.coordinated.ul with @width and @height might allow other approaches to describe rectangles in the future (not saying this is good or bad – just saying it becomes possible…).

following the suggestion, but need to check where else this is referenced…

Co-authored-by: Benjamin W. Bohl <bohl@em.uni-frankfurt.de>
@bwbohl
Copy link
Member

bwbohl commented Jun 27, 2023

@kepper could you please resolve conflicts and address the comments above?

Co-authored-by: Benjamin W. Bohl <bohl@em.uni-frankfurt.de>
ahankinson
ahankinson previously approved these changes Jul 10, 2023
@github-actions github-actions bot added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Type: Maintenance
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants