-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: resolve att def duplications #1157
Conversation
This is super, thanks. Please give me the time to have a proper look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kepper for this consolidation work.
Just for reference: I had another look at mensural stems, and I believe it's best to leave the situation as it is for now. We can revise as soon as we have the discussion around #1159 (which I'll push to someday…) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the work! Some ideas for improvements.
Also I'm a bit hesitant to extract |
@kepper Would you have time to address conflicts and comments? |
ping @kepper |
|
following the suggestion, but need to check where else this is referenced… Co-authored-by: Benjamin W. Bohl <bohl@em.uni-frankfurt.de>
@kepper could you please resolve conflicts and address the comments above? |
Co-authored-by: Benjamin W. Bohl <bohl@em.uni-frankfurt.de>
There are more than 100 attributes sharing their names with other attDefs. Most of them are perfectly sensible, because they are used in different contexts, and have quite different models – they just share their names, which are perfectly appropriate in their context. Sometimes, however,
<attDef>
s have just been copied over to not interfere with the class system. These cases are maintenance issues, which this PR tries to resolve. None of these changes should affect MEI instances.