Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: remove duplicated attributes to ensure schema validity #1261

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Jul 12, 2023

This pull request addresses and closes #1260 and fixes:

  • duplicate @func on <pgHead> and <pgFoot> by removing the unintentional reintroduction of a direct attribute definition in 7ce8ecd merging schema: resolve att def duplications #1157
  • deleting the <elementSpec ident="chord"> from the mei-basic customization which duplicated the membership of <chord> in att.stems

@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) labels Jul 12, 2023
@bwbohl bwbohl added Type: Bugfix indicates that a fix for a bug has been provided Status: Needs Review and removed Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) labels Jul 12, 2023
@bwbohl bwbohl added this to the MEI 5.0 milestone Jul 12, 2023
@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) labels Jul 12, 2023
@bwbohl
Copy link
Member Author

bwbohl commented Jul 12, 2023

thx @rettinghaus

@musicEnfanthen musicEnfanthen changed the title Fix: schema validity duplicate attributes schema: remove duplicated attributes to ensure schema validity Jul 12, 2023
@musicEnfanthen musicEnfanthen merged commit 5bb46ed into music-encoding:develop Jul 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Customizations changes to customizations/**/* (assigned automatically) Priority: Critical Type: Bugfix indicates that a fix for a bug has been provided
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

generated schemata invalid due to duplicate attributes
4 participants