Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for customizations #1171

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

kepper
Copy link
Member

@kepper kepper commented May 27, 2023

This adds a simple Schematron file that will validate customizations. Actually, it already brings up a couple of problems, which need to be fixed in a second step.

@kepper kepper added Component: Tools Status: Ready To Merge indicates that a pull request is ready for merging Type: Maintenance Component: Validation changes to source/validation/* (assigned automatically) labels May 27, 2023
@kepper kepper added this to the MEI 5.0 milestone May 27, 2023
@kepper kepper self-assigned this May 27, 2023
@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label May 27, 2023
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ahankinson
Copy link
Member

Will wait on merge for @bwbohl to have a look at this too.

@ahankinson ahankinson requested a review from bwbohl May 27, 2023 13:07
@musicEnfanthen musicEnfanthen added Status: Needs Review and removed Status: Ready To Merge indicates that a pull request is ready for merging labels May 27, 2023
@bwbohl bwbohl merged commit 7cf29b1 into develop May 30, 2023
1 check passed
@bwbohl bwbohl deleted the add-customization-validation branch May 30, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customizations changes to customizations/**/* (assigned automatically) Component: Tools Component: Validation changes to source/validation/* (assigned automatically) Type: Maintenance
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants