Fixed: Make customizations valid #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to remove these classes since they were defined on the CMN module, and it was not included.
The CMN module was not included, so model classes did not need to be deleted. Also fixed the name of an attribute class.
classSpecs are not valid in the "include"; only elementSpec.
The composer, arranger, and lyricist elements are defined in shared, not header.
these classSpec are commented out, so it was commented out here.
github-actions
bot
added
Component: Customizations
ahankinson
added
Priority: High
Status: Needs Review
Type: Bugfix
kepper
previously approved these changes
May 30, 2023
There was a problem hiding this comment.
In general, all fine. I would suggest to also give credit to @ahankinson, though…
bwbohl
reviewed
May 30, 2023
There was a problem hiding this comment.
Still got one validation error in mi-CMN.xml, at least on my machine.
System-ID: /Volumes/VCS/GitHub/bwbohl/music-encoding/customizations/mei-CMN.xml
Haupt-Validierungsdatei: /Volumes/VCS/GitHub/bwbohl/music-encoding/customizations/mei-CMN.xml
Schema: /Volumes/VCS/GitHub/bwbohl/music-encoding/source/validation/mei-customizations.sch
Programmname: ISO Schematron
Fehlerlevel: error
Beschreibung: There is no model class with name "model.scorePart.mensuralAndNeumes".
Anfang: 107:26
The model.scorePart.mensuralAndNeumes class is commented out in the spec, so it's commented out here.
|
@bwbohl fixed. |
bwbohl
approved these changes
May 30, 2023
|
thx @ahankinson |
rettinghaus
approved these changes
Jun 4, 2023
|
thx @rettinghaus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from #1171 and fixes errors in the customizations.
It should be merged after #1171, since it includes the changes from that PR.
The commits in this PR are separated by the individual changes and the commit message contains a short description on what the problem was.