Skip to content

Commit

Permalink
Fix #53.
Browse files Browse the repository at this point in the history
  • Loading branch information
musically-ut committed Aug 3, 2020
1 parent 1bdb5a9 commit d7f73c7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ The final archives are kept in the `./build` folder.

### Testing

The [`StandardJS` style checker](https://github.com/standard/standard) is used for setting the style guide
in the code.
The [`StandardJS` style checker](https://github.com/standard/standard) is used for setting the style guide in the code.

For testing, the extension can be loaded into Chrome by going to [chrome://extensions](chrome://extensions) and clicking on the <kbd>Load Unpacked Extension</kbd> button.
Then navigate to the `.tmp` folder in the source code root which was created by running `make chrome` and load it. An alternate is to run `make manifest` in the root folder and then load the source code root as the unpacked extension. This will allow for a simpler edit-reload cycle, except while editing `manifest.json.template`.
Expand Down
2 changes: 1 addition & 1 deletion manifest.template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Lovely forks",
"version": "3.4.0",
"version": "3.5.0",
"manifest_version": 2,
"description": "Show notable forks of GitHub projects.",
"homepage_url": "https://github.com/musically-ut/lovely-forks",
Expand Down
2 changes: 1 addition & 1 deletion webext/data/contentscript.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function getForksElement () {

// If the layout of the page changes, we'll have to change this location.
// We should make sure that we do not accidentally cause errors here.
const repoName = document.querySelector('.repohead > div > div')
const repoName = document.querySelector('main > div > div > div')
if (repoName) {
try {
text = document.createElement('span')
Expand Down
6 changes: 3 additions & 3 deletions webext/data/style.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* placeholder */
.repohead > div > div:not(.has-lovely-forks) {
padding-bottom: 12px;
main > div > div > div:not(.has-lovely-forks) {
padding-bottom: 20px;
}

/* smoother integration, show hierarchy */
Expand All @@ -20,5 +20,5 @@

/* icons */
.lovely-forks-addon img {
vertical-align: bottom;
vertical-align: middle;
}

0 comments on commit d7f73c7

Please sign in to comment.