Fix Tuplet Down Stem Bracket Position

tuplet.js :: fic positioning of bracket on down stems tuplet_tests.js :: Modify down stem tests
musomatt · Jan 28, 2013 · 979d84c · 979d84c
1 parent c9febb7
commit 979d84c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/tuplet.js b/src/tuplet.js
@@ -164,7 +164,7 @@ Vex.Flow.Tuplet.prototype.draw = function() {
     this.y_pos = first_note.getStave().getYForLine(4) + 20;
 
     for (var i=0; i<this.notes.length; ++i) {
-      var bottom_y = this.notes[i].getYs()[0] + 20;
+      var bottom_y = this.notes[i].getStemExtents().topY + 15;
       if (bottom_y > this.y_pos)
         this.y_pos = bottom_y;
     }

diff --git a/tests/tuplet_tests.js b/tests/tuplet_tests.js
@@ -148,15 +148,15 @@ Vex.Flow.Test.Tuplet.ratio = function(options) {
 }
 
 Vex.Flow.Test.Tuplet.bottom = function(options) {
-  var c = Vex.Flow.Test.Beam.setupContext(options);
+  var c = Vex.Flow.Test.Beam.setupContext(options, 350, 160);
   function newNote(note_struct) { return new Vex.Flow.StaveNote(note_struct); }
 
   var notes = [
-    newNote({ keys: ["f/5"], stem_direction: -1, duration: "q"}),
-    newNote({ keys: ["c/5"], stem_direction: -1, duration: "q"}),
-    newNote({ keys: ["d/5"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["f/4"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["c/4"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["g/4"], stem_direction: -1, duration: "q"}),
     newNote({ keys: ["d/5"], stem_direction: -1, duration: "8"}),
-    newNote({ keys: ["g/5"], stem_direction: -1, duration: "8"}),
+    newNote({ keys: ["g/3"], stem_direction: -1, duration: "8"}),
     newNote({ keys: ["b/4"], stem_direction: -1, duration: "8"})
   ];
 
@@ -190,13 +190,13 @@ Vex.Flow.Test.Tuplet.bottom = function(options) {
 }
 
 Vex.Flow.Test.Tuplet.bottom_ratio = function(options) {
-  var c = Vex.Flow.Test.Beam.setupContext(options);
+  var c = Vex.Flow.Test.Beam.setupContext(options, 350, 160);
   function newNote(note_struct) { return new Vex.Flow.StaveNote(note_struct); }
 
   var notes = [
-    newNote({ keys: ["f/5"], stem_direction: -1, duration: "q"}),
-    newNote({ keys: ["c/5"], stem_direction: -1, duration: "q"}),
-    newNote({ keys: ["d/5"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["f/4"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["c/4"], stem_direction: -1, duration: "q"}),
+    newNote({ keys: ["d/4"], stem_direction: -1, duration: "q"}),
     newNote({ keys: ["d/5"], stem_direction: -1, duration: "8"}),
     newNote({ keys: ["g/5"], stem_direction: -1, duration: "8"}),
     newNote({ keys: ["b/4"], stem_direction: -1, duration: "8"})