Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run hadouken shell script commands in development environment container #1

Open
xmkg opened this issue Jun 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@xmkg
Copy link
Owner

xmkg commented Jun 1, 2020

Currently, ./hadouken script is running in the environment which it is being invoked in. We should add an argument (--exec-in-devenv), which allows running the specified command in the development environment container.

When this new argument is supplied to the hadouken script;

  • development environment container defined in .devcontainer/docker-compose.yml should run
  • project root should be mounted into development environment container in 'bind' mode
  • ./hadouken script should be invoked in development environment project root with specified arguments (except --exec-in-devenv)

Script should be aware of the container instances had already been spawned previously by Visual Studio Code, and should try to use it first when available (instead of creating a new container from scratch).

@xmkg xmkg added the enhancement New feature or request label Jun 1, 2020
@xmkg xmkg self-assigned this Jun 1, 2020
@xmkg xmkg added this to the 0.12.0 milestone Jun 25, 2020
@xmkg xmkg removed this from the 0.12.0 milestone Sep 17, 2020
@xmkg xmkg removed their assignment Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant