Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload percentage calculation function #43

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

michaellimair
Copy link
Contributor

@michaellimair michaellimair commented Dec 14, 2020

Fix for issue #30

@dylanjha
Copy link
Contributor

Hi @michaellimair thanks so much for this 🙌 I'm very keen on getting this shipped.

It would be amazing to have some test coverage on this. On the surface here the changes look good, but the logic in there is a little difficult to reason about at first glance. We made significant improvements to the test ENV in #36

Do you think you might be able to take a stab at adding tests to this PR? (and bringing it up to date with upstream changes)?

@michaellimair
Copy link
Contributor Author

#36

Hi Dylan! Sure, will be working on this. Should I rebase from master or just merge the master branch to my working branch?

P.S: Props to the package, we have been using it in production for my company and it really helps 👯

@michaellimair michaellimair changed the title Fix upload percentage calculation function WIP: Fix upload percentage calculation function Jan 30, 2021
@dylanjha
Copy link
Contributor

@michaellimair thanks! Whichever you prefer. Either way we will squash the final merge

@michaellimair michaellimair changed the title WIP: Fix upload percentage calculation function Fix upload percentage calculation function Feb 8, 2021
@michaellimair
Copy link
Contributor Author

Hi @dylanjha, I have made a test case to check the progress event and ensure it does not jump backwards.

You can have a look, thanks 😄

@enormousrodent
Copy link

Do we have an idea when this will be merged back in to the master branch?

@dylanjha
Copy link
Contributor

@michaellimair wow, this looks great! 🙌🏼 🎉 Thank you for adding that extra test coverage.

@enormousrodent I'll work on getting a new release out in the next couple days!

@dylanjha dylanjha merged commit 3e85516 into muxinc:master Feb 22, 2021
@dylanjha dylanjha mentioned this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants