Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of ions to cfdicts and add it as an output to the print_coeffs file #13

Closed
mvdh7 opened this issue Jan 23, 2019 · 2 comments
Closed

Add list of ions to cfdicts and add it as an output to the print_coeffs file #13

mvdh7 opened this issue Jan 23, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@mvdh7
Copy link
Owner

mvdh7 commented Jan 23, 2019

Can it be auto-generated from the functions within? - should be possible, add a get_ions method

Also, auto-update the ions list when add_zeros is run
@mvdh7 mvdh7 added the enhancement New feature or request label Jan 23, 2019
@mvdh7
Copy link
Owner Author

mvdh7 commented Jan 23, 2019 •
edited
Loading

Also, add the source for each coefficient. Name of the function can be got with

# from coeffs
pz.coeffs.bC_cation_anion_source.__name__

# from cfdict
pz.cfdicts.CFDICT.bC['cation-anion'].__name__

@mvdh7
Copy link
Owner Author

mvdh7 commented Jan 24, 2019

All done, with new CoefficientDictionary method get_contents.

@mvdh7 mvdh7 closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdh7