New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JP outputs from jfuncs #16

Closed

mvdh7 opened this issue Jan 25, 2019 · 1 comment

Labels

Owner

mvdh7 commented Jan 25, 2019

They are not needed in an excess-Gibbs-energy-only model

Also, set up the Harvie JP function to be the derivative of the corresponding J with autograd, instead of using scipy numerical derivative

mvdh7 added the enhancement label

Owner Author

mvdh7 commented Jan 28, 2019

Both done

mvdh7 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment