Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin support, fixes #156 #173

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Cygwin support, fixes #156 #173

merged 1 commit into from
Oct 29, 2020

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 29, 2020

No description provided.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 29, 2020

Is the new cygwin path resolution executed on client, daemon or both?

I wonder, whether something like the following would work?

  1. Daemon started by a request coming from a cygwin client
  2. A subsequent request is done from cmd.exe shell

(or the other way round)

@gnodet
Copy link
Contributor Author

gnodet commented Oct 29, 2020

Is the new cygwin path resolution executed on client, daemon or both?

I wonder, whether something like the following would work?

  1. Daemon started by a request coming from a cygwin client
  2. A subsequent request is done from cmd.exe shell

(or the other way round)

I agree it should work. The fact that code transforms all paths to actual windows paths should make it work in all cases I think.

@gnodet gnodet marked this pull request as ready for review October 29, 2020 10:52
@gnodet gnodet merged commit b94e34e into apache:master Oct 29, 2020
@gnodet gnodet deleted the cygwin branch November 4, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants