-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #81
Improvements #81
Conversation
@@ -60,6 +60,9 @@ | |||
<exclusion id="*:plexus-sec-dispatcher"/> | |||
<exclusion id="*:plexus-utils"/> | |||
</artifact> | |||
<artifact id="org.jboss.fuse.mvnd:mvnd-client:${project.version}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the client in lib/ext? - to fix the mvns script?
Maybe, but at least for the `mvnd.sh` script.
Le lun. 5 oct. 2020 à 12:53, Peter Palaga <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In daemon/src/main/provisio/maven-distro.xml
<#81 (comment)>:
> @@ -60,6 +60,9 @@
<exclusion id="*:plexus-sec-dispatcher"/>
<exclusion id="*:plexus-utils"/>
</artifact>
+ <artifact id="org.jboss.fuse.mvnd:mvnd-client:${project.version}">
Why do we need the client in lib/ext? - to fix the mvns script?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#81 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUQNT626PK5QSPD3H3KV3SJGQTLANCNFSM4SEQTZVA>
.
--
-----------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration
Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/
|
|
Hm... not sure what will happen when the server is run via native client on Java 8. The client.jar will be loaded together with other libs in lib/ext, but the client.jar requires Java 11. Maybe it will cause some issues. If so, we should perhaps move client.jar to a separate directory, e.g. bootstap-client |
Maybe I'm missing something, but it seems to me that currently, the |
The goal to make mvnd.sh usable again is fine, I just have concerns about the means. In particular, that the current fix may cause a new issue. Let me check whether I am right at all. |
I have just tested native mvnd with JAVA_HOME pointing at Java 8 and it works. |
No description provided.