Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #81

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Improvements #81

merged 3 commits into from
Oct 5, 2020

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 5, 2020

No description provided.

@@ -60,6 +60,9 @@
<exclusion id="*:plexus-sec-dispatcher"/>
<exclusion id="*:plexus-utils"/>
</artifact>
<artifact id="org.jboss.fuse.mvnd:mvnd-client:${project.version}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the client in lib/ext? - to fix the mvns script?

@gnodet gnodet merged commit 72b164b into apache:master Oct 5, 2020
@gnodet
Copy link
Contributor Author

gnodet commented Oct 5, 2020 via email

@ppalaga
Copy link
Contributor

ppalaga commented Oct 5, 2020

at least for the mvnd.sh script.

mvnd.sh will thus require Java 11. Maybe we should document it somewhere.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 5, 2020

Hm... not sure what will happen when the server is run via native client on Java 8. The client.jar will be loaded together with other libs in lib/ext, but the client.jar requires Java 11. Maybe it will cause some issues. If so, we should perhaps move client.jar to a separate directory, e.g. bootstap-client

@gnodet
Copy link
Contributor Author

gnodet commented Oct 5, 2020

Maybe I'm missing something, but it seems to me that currently, the mvnd.sh script is unusable, so I'm trying to fix that (and trying to avoid the native step while developing...)

@ppalaga
Copy link
Contributor

ppalaga commented Oct 5, 2020

The goal to make mvnd.sh usable again is fine, I just have concerns about the means. In particular, that the current fix may cause a new issue. Let me check whether I am right at all.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 5, 2020

I have just tested native mvnd with JAVA_HOME pointing at Java 8 and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants