Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md for iOS is probably wrong #33

Closed
HironobuIga opened this issue Oct 14, 2020 · 3 comments
Closed

README.md for iOS is probably wrong #33

HironobuIga opened this issue Oct 14, 2020 · 3 comments

Comments

@HironobuIga
Copy link

I added code below to AppDelegate.swift following README.md.

UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate

Then I found that connector.configure(~) method didn't be called.
When I deleted it from AppDelegate.swift, connector.configure was called.

So I think there may be mistake in README.md.

@szotp
Copy link
Contributor

szotp commented Oct 23, 2020

Strange, but this method is required. And firebase_messaging also mentions it: https://pub.dev/packages/firebase_messaging

If you delete this line then app should actually fail with assertionFailure.

If I'm wrong then please provide some sample code.

@HironobuIga
Copy link
Author

Thank you for your check.Yes, I think it's strange...I will try to make minimum sample of this issue, pls wait a while.

@szotp
Copy link
Contributor

szotp commented Dec 4, 2020

Please reopen if you have more details, AFAIK that line is necessary.

@szotp szotp closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants