Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for customising the useragent #16

Merged
merged 2 commits into from Mar 22, 2013
Merged

Conversation

eug48
Copy link
Contributor

@eug48 eug48 commented Mar 21, 2013

No description provided.

eug48 added 2 commits March 21, 2013 15:30
This is needed to nicely use the MediaWiki API.
@waldyrious
Copy link
Member

Hi @eug48, thanks for the PR! As a result of working in the svn-->git transition, I do have commit rights in this repo, but I haven't worked with mwclient development itself enough to feel confident about merging your commits right away. Could you add a brief explanation for the rationale of the changes? Thanks :)

@eug48
Copy link
Contributor Author

eug48 commented Mar 22, 2013

Ok, sure @Waldir. When mwclient sends a request it includes a "Useragent" HTTP header that used to be set to "MwClient". However, this doesn't let the administrators of Wikipedia for example, identify the actual program that's making requests as all programs using mwclient look the same. According to the MediaWiki API docs (see http://www.mediawiki.org/wiki/API:Main_page#Identifying_your_client) they want to be able to identify each client individually.

waldyrious added a commit that referenced this pull request Mar 22, 2013
Support for customising the useragent and remove unused Request class
@waldyrious waldyrious merged commit b1b2621 into mwclient:master Mar 22, 2013
@waldyrious
Copy link
Member

Thanks. From what I can see, it looks good, I'll merge.

@waldyrious waldyrious mentioned this pull request May 13, 2013
@waldyrious waldyrious added this to the v0.7 milestone Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants