Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not change Height? #56

Open
MarioElHazard opened this issue Jun 9, 2023 · 4 comments
Open

Can not change Height? #56

MarioElHazard opened this issue Jun 9, 2023 · 4 comments

Comments

@MarioElHazard
Copy link

If the Height parameter in VThreadProfile is changed the Additive Pipe breaks. In report view: "Recompute failed! Please check report view." If a new VThreadProfile is started any Height can be given but not changed after the AdditivePipe is made.

FreeCAD 0.20 29177 - 2022/06/13
ThreadProfile version 1,85

image

@mwganson
Copy link
Owner

mwganson commented Jun 9, 2023

Thanks for the report. FreeCAD has changed by adding a new property to the Helix object called SegmentLength. If set to 0 (default) you no longer get segmented helices, which is good, but which also breaks the workbench. I have attempted to resolve this while also maintaining compatibility with earlier versions. New version is 1.86. Please update and test the new version and report back here.

@MarioElHazard
Copy link
Author

Thanks for your quick response. Updated to 1.86.
Now height can be changed. But if the pitch is changed the height of the helix changes in the model (VThreadProfile.ThreadCount * VThreadProfile.Pitch). However, the number of height in Thread Profile panel stays the same. Also the ThreadCount does not update when the pitch is changed.

image

@mwganson
Copy link
Owner

mwganson commented Jun 10, 2023

New version 1.87. Please update and test again. Thanks.

Edit: Please also check that existing models are not broken.

@MarioElHazard
Copy link
Author

Works fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants