-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with jupyter-fs=1.0.0
#1239
Comments
Hi @mahendrapaipuri , yes that's correct, I have not made significant progress on the async contents manager. From what I remember the impact was very big and I did not identify a big demand for that. Of course I am happy to reconsider and restart that work! Yes I did saw the incompatibility between |
Well, we should clearly document the compatbility with We should look into base classes (the classes that current contents manager has dervied from) and check if they are based on What do you think? |
jupyter-fs 1.0.0
has landed last week and now it usesAsyncContentsManager
by default in itsMetaManager
. When used along withjupytext
, this will be broken asjupytext
, for the moment, only supports syncContentsManager
. There is a stale PR #1021 that attempts to addAsyncContentsManager
support tojupytext
but has not progressed in a while.Probably we should document clearly that
jupytext
is only compatible withSyncMetaManager
ofjupyter-fs
that has been added in1.0.0
. In factjupytef-fs>0.3.1
usesAsyncContentsManager
by default andSyncMetaManager
is only added in1.0.0
. So, I guess for thejupyter-fs
versions0.4.0
and0.4.1
,jupytext
is not compatible.@mwouts Did you have an opportunity to look into it? Cheers!
The text was updated successfully, but these errors were encountered: