Resource nested hash support #42

Merged
merged 2 commits into from Nov 19, 2013

Conversation

Projects
None yet
2 participants
@artempartos
Contributor

artempartos commented Nov 19, 2013

I use Weary for my client. In some my API i use ransack and often i have a nested hash in params. For example i have rest people index api, where three hash keys.

get :people, "/api/people.json" do |resource|
      resource.optional :q, :per_page, :page
end

Here page and per_page integer option, and q - ransack search nested hash.
for example q[description_cont] or q[year_eq].
But with Weary::Resource i have error (test illustrate it)

 TypeError:
       Can't convert Hash into String.

It's famous addresable issue sporkmonger/addressable#36 which fixed in addresable 2.2.7 and broken in addresable 2.3.
I decide fix this bug here, because addresable maintainer doss't want do it (sporkmonger/addressable#84) and
minor version of Weary is higher than 2.2.

mwunsch added a commit that referenced this pull request Nov 19, 2013

@mwunsch mwunsch merged commit ef7ac66 into mwunsch:master Nov 19, 2013

1 check passed

default The Travis CI build passed
Details

@artempartos artempartos deleted the artempartos:feature/nested_hash_params branch Nov 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment