Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Clean up Room Detection code. #133

Closed
mxashlynn opened this issue Jun 23, 2019 · 4 comments
Closed

Clean up Room Detection code. #133

mxashlynn opened this issue Jun 23, 2019 · 4 comments
Assignees
@mxashlynn
Milestone
Pre-Alpha 1

Comments

@mxashlynn
Copy link
Owner

mxashlynn commented Jun 23, 2019 •
edited

  • See if we can deduplicate search and traverse routines✔️
  • See if employing DFS-ID helps ✔️
  • Move room mins and maxes (as well as Map dimensions) from All into a dedicated Rules class✔️
  • Consider doing Differentiate PerimeterEntry from WalkableEntry properties. #91 as part of this✔️
  • Add new unit tests to Vector2Int and Space classes:
    • Test finding neighboring spaces via Space struct✔️
    • Test addition, subtraction, and multiplication routines in Vector2Int✔️

The branch https://github.com/mxashlynn/Parquet/tree/room-detection-cleanup is intended for this work.
@mxashlynn mxashlynn added this to the Pre-Alpha 1 milestone Jun 23, 2019
@mxashlynn mxashlynn self-assigned this Jun 23, 2019
@mxashlynn
Copy link
Owner Author

mxashlynn commented Jun 24, 2019 •
edited

Take care of all TODOs in the RoomCollection class file. ✔️

@mxashlynn
Copy link
Owner Author

mxashlynn commented Jun 27, 2019 •
edited

Eliminate caching, as it's early days still and we haven't profiled yet. ✔️

@mxashlynn
Copy link
Owner Author

mxashlynn commented Aug 5, 2019 •
edited

Double check that correct perimeters are being attached to walkable areas. ✔️

@mxashlynn mxashlynn mentioned this issue Aug 8, 2019
Merged
@mxashlynn
Copy link
Owner Author

Done as of #139 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mxashlynn mxashlynn

Labels
None yet
Projects
None yet
Milestone
Pre-Alpha 1
Development

No branches or pull requests
1 participant
@mxashlynn