Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1332 #1342

Merged
merged 9 commits into from
May 11, 2024
Merged

Fix #1332 #1342

merged 9 commits into from
May 11, 2024

Conversation

RomanPodymov
Copy link
Collaborator

Hello.
Thank you for PromiseKit.
Fix #1332.

RomanPodymov and others added 3 commits September 30, 2023 20:54
Co-authored-by: Max Howell <mxcl@me.com>
@RomanPodymov RomanPodymov marked this pull request as draft April 6, 2024 11:04
@RomanPodymov RomanPodymov mentioned this pull request Apr 10, 2024
@mxcl
Copy link
Owner

mxcl commented May 8, 2024

Is this ready?

@RomanPodymov
Copy link
Collaborator Author

Is this ready?

Hello @mxcl
Not yet, SPM is failing. Or maybe I can fix SPM later.

@RomanPodymov RomanPodymov marked this pull request as ready for review May 11, 2024 00:09
@RomanPodymov
Copy link
Collaborator Author

Is this ready?

Now it's ready.

@RomanPodymov RomanPodymov merged commit 4c31ef1 into mxcl:master May 11, 2024
15 checks passed
@RomanPodymov RomanPodymov deleted the feature/privacy_manifest branch May 11, 2024 07:57
@jayeshkawli
Copy link

@RomanPodymov Thank you for the fix. Much appreciated. Can we also make a release so that we can update our dependencies?

@RomanPodymov
Copy link
Collaborator Author

Hello @jayeshkawli
Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

@jayeshkawli
Copy link

Hello @jayeshkawli Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

I am not sure what you mean, can you please elaborate? To my original question, I meant making a next release like from this page https://github.com/mxcl/PromiseKit/releases so that we can fetch this change through SPM/Cocoapods. Or I can also do that if I have necessary permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Manifest
3 participants