This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Fix qt5 HEAD #23890
Closed
Fix qt5 HEAD #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I only changed how HEAD builds are made, so obviously the tests are irrelevant here. |
| # Qt components need to be in their Git repos to build HEAD. | ||
| sub_cmd = %W{ln -s #{downloader.cached_location}/$path/.git #{Dir.pwd}/$path/.git} | ||
| cd downloader.cached_location do | ||
| safe_system 'git', 'submodule', '--quiet', 'foreach', *sub_cmd |
There was a problem hiding this comment.
Our HEAD checkout should support submodules? Would be good to know if we can fix this somehow.
There was a problem hiding this comment.
Our HEAD checkout should use Qt 5's own init-repository script.
|
@MikeMcQuaid I now use |
| ohai "Checking out #@ref_type #@ref" | ||
| else | ||
| @clone.cd { reset } | ||
| end |
There was a problem hiding this comment.
Taken straight from GitDownloadStrategy#stage, no idea.
|
@MikeMcQuaid Ping? |
yriveiro
pushed a commit
to yriveiro/homebrew
that referenced
this pull request
Nov 26, 2013
Closes Homebrew#23890. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
ehershey
pushed a commit
to ehershey/homebrew
that referenced
this pull request
Apr 4, 2014
Closes Homebrew#23890. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.