Bitcoin Formula

[sidupadhyay]

This is a new formula for Bitcoin, which addresses the issues from a previous attempt by @melek-bitcoin, see: Issue #4472 and Issue #4461.

The original issue was a dependency on Berkeley-DB 4.x, which is not provided in the standard installation of homebrew. Thus a formula from the homebrew-alt repo is used and by default this formula installs bitcoin in keg_only mode, as suggested by @adamv.

This formula provides the necessary caveats to install Bitcoin manually and also provides an optional flag to link bitcoind, if the user chooses to do so. Additionally, this new version reduces the download time of Bitcoin by pulling straight from the git repo on github, instead of the larger package on sourceforge.

[adamv]

This patch needs to go upstream.

[sidupadhyay]

@adamv it seems the Bitcoin formula was never accepted the first time. The patch I provided is due to inconsistencies in the makefile for OS X on the Bitcoin github repo. This pull request should merge cleanly.

[sidupadhyay]

@adamv, I updated the formula to use a tarball and pushed upstream. Do you see any other changes that should be incorporated?

[adamv]

@mxcl @MikeMcQuaid - Max, Mike, merge this if you want; I'm disabling notifcations.

[mxcl]

So… sorry I'm late to this.

How about installing berkley db 4 into the bitcoin keg? Since it is required, it needs to be installed. I apologise for our policies that are making this hard, but it really doesn't work great to install lots of the same thing in parallel.

If you haven't seen such things then I recommend the git formula which does something similar.

Then install bdb4 with a prefix which is the bitcoin_prefix/bdb and make bitcoin know to get it there when it builds.

Or if possible you can compile the bdb bits statically, and get bitcoin to link to that and then you might have less of a headache.

Another option is to be clever and invent someway for failed deps check to spew out some text. So you could tell the user how to install the bdb4 dep. But frankly I think installing it in the bitcoin keg is more convenient for the user that just wants to use this tool.

[sidupadhyay]

Max, no this is my fault--its my first time submitting a formula. Thanks for pointing out the git formula. I'll check it out and give this another shot.

[mxcl]

Well, I wouldn't say it was your fault. You’re doing something Homebrew isn't good at, which would make it my fault. Thank you for this interesting formula contribution and I apologise that it is not an easy submission for you. And feel free to ask me for questions, as I haven't been that clear in the above details.

[MikeMcQuaid]

Any luck with this? If not, I can perhaps help.

[sidupadhyay]

Wow, I totally missed Max's message. I assumed this was closed some time ago.

Mike, you're welcome to fix this up. I know you're much more familiar with homebrew and submitting patches :)

[MikeMcQuaid]

Cheers dude, will try and take a look.

[MikeMcQuaid]

Actually, had a look and they appear to ship a decent binary version with new releases in a DMG so I don't see the advantage in including this I'm afraid (particularly given it needs a bit of work). Sorry, closing.

[sidupadhyay]

That's a much better solution! Thanks Mike!

Sent from my iPhone

On Jan 24, 2012, at 1:21 PM, Mike McQuaid
reply@reply.github.com
wrote:

Actually, had a look and they appear to ship a decent binary version with new releases in a DMG so I don't see the advantage in including this I'm afraid (particularly given it needs a bit of work). Sorry, closing.

---

Reply to this email directly or view it on GitHub:
#6110 (comment)

[barmstrong]

Just wanted to add that they don't include bitcoind for some reason in the Mac DMG, so it would still be useful to build it locally. Gavin talks a bit about it here: bitcoin/bitcoin#664 If it's a ton of work though obviously a judgement call for homebrew - it sounds like there is a work around with sending Json-RPC calls to Bitcoin-QT.

[sidupadhyay]

I don't think this is worth the trouble of adding to homebrew any more. Reading through the bitcoin stackexchange pages and the forums it seems like people are referencing: http://bitcoin.stackexchange.com/questions/793/what-are-the-steps-in-building-bitcoind-on-mac-os-x-10-6 And even then the view count of the page is fairly low.