Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌘+drag not working #16

Closed
jariz opened this issue Feb 20, 2019 · 6 comments
Closed

⌘+drag not working #16

jariz opened this issue Feb 20, 2019 · 6 comments

Comments

@jariz
Copy link

jariz commented Feb 20, 2019

Hiya, great tool! However, not that keen on having it in my menubar at all times.
Bartender can't seem to control it, however.

Are you doing something non-standard or something?
Haven't really ran into any apps that bartender can't handle.

@mxcl
Copy link
Owner

mxcl commented Feb 20, 2019

We’re not doing anything non-standard.

If the Bartender developers want to investigate, our sources are available for them to read.

@jariz
Copy link
Author

jariz commented Feb 20, 2019

I'll shoot them a message, thanks.

@jariz jariz closed this as completed Feb 20, 2019
@bensurtees
Copy link
Contributor

Hi, I am the developer of Bartender, the issue is that Bartender uses the macOS default behaviour of ⌘+dragging menu items to reposition/order them in the menu bar (try this on other menu items, they should drag and reposition themselves, except Notification Center which isn't allowed to move).
This does not work with workbench (regardless of Bartender running) this is because in workbench you are overriding this behaviour by catching events before they go through the StatusItemWindow sendEvent (which handles this) by using a localeventmonitor (which gets the events first), which is okay, but you just want to check to see if ⌘ is pressed (check the event. modifierFlags) and allow that event to pass through (return event) without triggering self?.onStatusBarItemClicked()
You should then get the dragging behaviour back, and as an added bonus Bartender will work with it.

Let me know if you need more info or anything.

Ben

@bensurtees
Copy link
Contributor

I created a pull request with what I believe should be a fix ( I didn't compile workbench to test it)

@jariz jariz reopened this Feb 21, 2019
@jariz jariz changed the title Bartender can't control workbench ⌘+drag not working Feb 21, 2019
@mxcl
Copy link
Owner

mxcl commented Feb 21, 2019

My bad, we were doing something non-standard. New build on its way.

@mxcl
Copy link
Owner

mxcl commented Feb 21, 2019

Workbench 1.0.1 is available and I have confirmed you can now ⌘-drag.

To force an update hold ⌥ and click the cog menu, the item “Check for updates” will appear. The new version will download and restart, you can verify the version is 1.0.1 by looking in the bottom left of the popup.

@mxcl mxcl closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants