Some tests improvements #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with the behaviour of the actual function, which always returns a string, and would have avoided introducing an error in dc9bdec (Fix validation of tmake-server-xxx options, 2022-02-12)
In addition to checking for the options validation, also check that not having any options and using the defaults works too.
Remove the extraneous "be" from recurrent "should be handle" typo. No real changes.
This avoids cluttering the tests output with these messages, each of which is given once per test.
|
@mxschmitt FWIW I will not tag a new release because there are not really any user-visible changes in this here PR, just a lot of future-proofing, which I like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having any more problems like the one from #105, I've changed the mock function in the tests return empty string rather than
undefinedwhen the option is not defined, to be consistent with the real function and added a new test checking that everything works without any options being set.I've also made 2 other cosmetic changes that could be [not] applied independently of the 2 other ones to make test output nicer to read.
Sorry again for the breakage!