-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: upgrade nodejs runtime from v12 to v16 #120
runtime: upgrade nodejs runtime from v12 to v16 #120
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Should be a version bump after the PR merge. Thanks! |
@@ -29,7 +29,7 @@ | |||
"devDependencies": { | |||
"@babel/core": "^7.15.0", | |||
"@babel/preset-env": "^7.15.0", | |||
"@vercel/ncc": "^0.29.0", | |||
"@vercel/ncc": "^0.33.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the reasoning behind bumping ncc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reasoning, but just thinking to use the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this one in mind, vercel/ncc#801
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!
Thanks @mxschmitt ! |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.