Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing functionality/methods #34

Closed
4 tasks done
mxschmitt opened this issue Sep 7, 2020 · 6 comments · Fixed by #96
Closed
4 tasks done

Add missing functionality/methods #34

mxschmitt opened this issue Sep 7, 2020 · 6 comments · Fixed by #96
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mxschmitt
Copy link
Member

mxschmitt commented Sep 7, 2020 •
edited
Loading

Current report (node scripts/validate-interfaces.js):

Missing API interface functions:

  • BrowserContext.SetHTTPCredentials
  • BrowserContext.StorageState
  • ElementHandle.WaitForElementState
  • ElementHandle.WaitForSelector
@mxschmitt mxschmitt self-assigned this Sep 7, 2020
@mxschmitt mxschmitt changed the title Validate full API existence and parameters Validate full API existence Sep 7, 2020
@mxschmitt mxschmitt added the enhancement New feature or request label Sep 8, 2020
This was referenced Sep 12, 2020
Merged
Merged
Merged
@tutturen
Copy link

tutturen commented Nov 2, 2020

Hi Max,

Great project you have here, I like it a lot. I want to use this in one of my projects, but the pages contain a lot of dropdowns, which I don't know how to handle at the moment without Page.selectOption. Is implementing Page.selectOption currently on your roadmap? If not, can you point me in the right direction for me to implement it?

@mxschmitt
Copy link
Member Author

Hi, if you want feel free to add it yourself as Pull Request, as a reference it might just need a 1:1 wrapper from Playwright for Python and some tests. If you don't feel comfortable, then I can also implement it, probably during end of the week.

@tutturen
Copy link

tutturen commented Nov 3, 2020 •
edited
Loading

Thanks! I will take a stab at it if I get the time before the weekend.

@tutturen
Copy link

tutturen commented Dec 7, 2020

I just wanted to inform you that I did not find the time to fix the issue. Sorry about that.

This was referenced Dec 28, 2020
Merged
Merged
@lcmtwn lcmtwn mentioned this issue Dec 29, 2020
Merged
@mxschmitt mxschmitt added the good first issue Good for newcomers label Dec 29, 2020
@mxschmitt mxschmitt changed the title Validate full API existence Add missing functionality/methods Dec 29, 2020
@lcmtwn lcmtwn mentioned this issue Dec 31, 2020
Merged
@mxschmitt mxschmitt mentioned this issue Dec 31, 2020
Merged
@mxschmitt mxschmitt removed their assignment Dec 31, 2020
@mxschmitt mxschmitt mentioned this issue Jan 3, 2021
Merged
@lcmtwn lcmtwn mentioned this issue Jan 4, 2021
Merged
@mxschmitt mxschmitt mentioned this issue Jan 23, 2021
Merged
@mxschmitt
Copy link
Member Author

@tutturen FYI a few weeks ago SelectOption was added by @lcmtwn 🚀

@tutturen
Copy link

That is nice! Thanks for letting me know!

@mxschmitt mxschmitt mentioned this issue Jan 23, 2021
Merged
@lcmtwn lcmtwn mentioned this issue Jan 24, 2021
Merged
@mxschmitt mxschmitt linked a pull request Jan 24, 2021 that will close this issue
feat: add storage state support #96
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add storage state support playwright-community/playwright-go
2 participants
@tutturen @mxschmitt