-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to warning lines to make it less ambigous and problems directly addressable #6
Comments
Yes you are right, in the GUI the warnings store a reference to the affected part if possible, and you can navigate there by double-click. So I understand the need for some more help in the CLI. |
Well, the warnings have an affected thing and the message goes like: parent thing -> affected thing : message In many cases the affected thing is a part, so the parent will be the vessel and its name will show up in the warning message already. In other cases the problem is identified on a specific attribute, which then is the affected thing, having the parent to be the part or whatever node. The next level up, like vessel, is not shown in this case. I'm thinking about displaying the affected thing besides the warning in the CLI. Not every affected thing is a part and has a uid, so I'd rather restrain from being that specific. But if it is a part, showing it will give you the uid. |
@darthgently Would this help? Selecting a specific warning like
And maybe I should in general show "node's parent -> node -> attrib" for warnings about attributes and stay with "node's parent -> node" for warnings about nodes. |
Implemented always showing 2 nodes, even for warnings about attributes ee158f8 This should do? I might release it later today. |
I'm not seeing ship name in current warnings. Fwiw, -v option reports earlier version than most recent but zip I am using is named as most recent and is most recent on site for download |
Your suggestions address things 100% |
Yes I noticed that I did a few previous releases wrong and didn't update the version in the Mono assembly info, I fixed that as well. |
Released in v0.9.4 |
Specifically, uid of part in warning entry would allow searching within the savefile to the specific craft and part directly.
Maybe craft name would be nice but not necessary. For context I am only using the CLI mono version and only plan to use this version as it it can be driven by script with low overhead. So the request is for mono version. As far as I know the GUI version may already address this in another way.
The text was updated successfully, but these errors were encountered: