The logic regarding transaction rollback seems incorrect

[xutengx]

src/main/java/org/mybatis/spring/transaction/SpringManagedTransaction.java

/**
   * {@inheritDoc}
   */
  @Override
  public void rollback() throws SQLException {
    if (this.connection != null && !this.isConnectionTransactional && !this.autoCommit) {
      LOGGER.debug(() -> "Rolling back JDBC Connection [" + this.connection + "]");
      this.connection.rollback();
    }
  }

this.connection != null && !this.isConnectionTransactional && !this.autoCommit

[harawata]

Hello @xutengx ,

We need the details about the problem caused by the referenced code.

[xutengx]

Hi,
My service code :

@Service
public class TService {
      @Resource
      private StudentMapper studentMapper;
      
      @Transactional(rollbackFor = TestException.class)
      public void doSomething(int id, int age) throws TestException {
          studentMapper.updateAgeById(id, age);
          throw new TestException();
      }
}

My mapper code :

@Mapper
public interface StudentMapper {
    @Update("update student set age = #{age} where id = #{id}")
    int updateAgeById(@Param("id") Integer id, @Param("age") Integer age);
}

My business code :

@Resource
private TService tService;

@Test
void test() {
    try {
        tService.doSomething(id, newAge);
    } catch (TestException e) {
        System.out.println("exception");
    }
}

---

In SpringManagedTransaction

 @Override
  public void rollback() throws SQLException {
    // this.connection != null                                 true
    // !this.isConnectionTransactional                   false
    // !this.autoCommit                                         true
    if (this.connection != null && !this.isConnectionTransactional && !this.autoCommit) {
      //  will not execute
      LOGGER.debug(() -> "Rolling back JDBC Connection [" + this.connection + "]");
      this.connection.rollback();
    }
  }

  @Override
  public void close() throws SQLException {
    // execute this logic
    DataSourceUtils.releaseConnection(this.connection, this.dataSource);
  }

The problem is that when only one transaction manager is used and the connection is closed without rollback, there is no problem.
However, when there are multiple transaction managers, closing the connection without rollback can lead to errors.

[harawata]

@xutengx ,

Please post the stack trace of the error.
It seems that the issue requires complex configuration for reproduction, so please create a repro project with minimum setup and share it on your repo.
Here are some project templates : https://github.com/harawata/mybatis-issues