Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle orphaned data #197

Open
JN-Jones opened this issue May 7, 2016 · 0 comments
Open

Handle orphaned data #197

JN-Jones opened this issue May 7, 2016 · 0 comments
Labels
t:enhancement Type: Enhancement. Contains minor improvements

Comments

@JN-Jones
Copy link
Contributor

JN-Jones commented May 7, 2016

We already had an issue with orphaned attachment and while writing the vb5 module I had the same issue with posts. As a simple solution is possible for nearly all modules it should be added. After the prepare_insert_array (also after the log call) simply add

        // An orphaned post which isn't associated with any thread. We can't handle those for several reasons so trick them
        if($insert_array['tid'] < 1)
        {
            $this->increment_tracker('posts');
            $output->print_progress('end');
            return 0;
        }

Ofc modified for the module (tid and posts replaced with the correct variables)

@JN-Jones JN-Jones added the t:enhancement Type: Enhancement. Contains minor improvements label May 7, 2016
@JN-Jones JN-Jones added this to the 1.8.8 milestone May 7, 2016
@Stefan-MyBB Stefan-MyBB removed this from the 1.8.8 milestone Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

2 participants