[1.8][bug] $theme['editortheme'] is null

[ATofighi]

Hi,
In admin/inc/class_page.php line 774 ( https://github.com/mybb/mybb/blob/feature/admin/inc/class_page.php#L774 )
$theme['editortheme'] is null, it must be mybb.css

---

Fixes in #663

[martec]

sorry @ ATofighi but this not fix.
Load twice mybb.css...
But need load instead jquery.sceditor.default.min.css to style blockquote etc... (http://i.imgur.com/hZUOtKZ.png)

http://i.imgur.com/bLSHIEk.png
i get image above in www.sceditor.com

you can check that minified/themes/default.min.css and minified/jquery.sceditor.default.min.css not are same file.

And you can check too sceditor plugin to mybb made by samclarke that load two style different.

[ATofighi]

@martec please see codebuttons template and source of new thread page

<link rel="stylesheet" href="jscripts/sceditor/editor_themes/mybb.css" type="text/css" media="all" />
<script type="text/javascript" src="jscripts/sceditor/jquery.sceditor.bbcode.min.js"></script>
<script type="text/javascript" src="jscripts/bbcodes_sceditor.js"></script>
<script type="text/javascript" src="jscripts/sceditor/editor_languages/en.js"></script>
<script type="text/javascript">
$(function() {
    $("#message").sceditor({
        plugins: "bbcode",
        style: "jscripts/sceditor/editor_themes/mybb.css",
        rtl: 0,
        locale: "en",
        emoticons: {
            // Emoticons to be included in the dropdown
            dropdown: {
                ":s": "images/smilies/confused.png",
                ":-/": "images/smilies/undecided.png",
                ":)": "images/smilies/smile.png",
                ";)": "images/smilies/wink.png",
                ":D": "images/smilies/biggrin.png",
                ":P": "images/smilies/tongue.png",
                ":(": "images/smilies/sad.png",
                ":@": "images/smilies/angry.png",
                ":blush:": "images/smilies/blush.png",
            },
            // Emoticons to be included in the more section
            more: {
                ":angel:": "images/smilies/angel.png",
                ":dodgy:": "images/smilies/dodgy.png",
                ":exclamation:": "images/smilies/exclamation.png",
                ":heart:": "images/smilies/heart.png",
                ":huh:": "images/smilies/huh.png",
                ":idea:": "images/smilies/lightbulb.png",
                ":sleepy:": "images/smilies/sleepy.png",
                ":cool:": "images/smilies/cool.png",
                ":rolleyes:": "images/smilies/rolleyes.png",
                ":shy:": "images/smilies/shy.png",
                ":at:": "images/smilies/at.png"
            }
        },
        toolbar: "bold,italic,underline,strike|left,center,right,justify|font,size,color,removeformat|horizontalrule,image,email,link,unlink|video,emoticon|bulletlist,orderedlist|code,quote|maximize,source",
    });

    MyBBEditor = $("#message").sceditor("instance");
});
</script>

it is mybb.css not jquery.sceditor.default.min.css :)
But jquery.sceditor.default.min.css is missed.

[martec]

@ATofighi

what you trying say? not change anything... this above call jscripts/sceditor/editor_themes/mybb.css twice...
plz check what i said in #667, #668 and #420

[ATofighi]

@martec mybb.css use in link tag and style: , please see codebuttons template.
but jquery.sceditor.bbcode.min.js only use in link tag.

[martec]

@ATofighi
don´t correct...
you need check plugin made by @samclarke, author of sceditor.
https://github.com/samclarke/SCEditor-MyBB

link is used to style editor (mybb.css)...
and "style:" used to style codeblock, quoteblock etc (jquery.sceditor.default.min.css)...

[martec]

@ATofighi

i will repeat here what i said in #667

Quote tag without jquery.sceditor.default.min.css
http://i.imgur.com/JcFmTjl.png

Quote tag with jquery.sceditor.default.min.css
http://i.imgur.com/hZUOtKZ.png

In http://www.sceditor.com/

link
http://i.imgur.com/tp1rwXO.png minified/themes/default.min.css (is same of mybb.css (customization of default.css))

"style:" into script: http://i.imgur.com/bTyYjf8.png minified/jquery.sceditor.default.min.css (not same file above) (this used to style code, quote blocks)
but better used jquery.sceditor.mybb.css from sceditor mybb plugin (this customization of file jquery.sceditor.default.min.css) has betteer style to codeblock and blockquote. #668 or say to @justinsoltesz to made one better style (customizaton of file jquery.sceditor.default.min.css)

[ATofighi]

OK. ;)

[DiogoParrinha]

I think there is a bit of confusion here. The issue is simple: $theme is not defined (we're not globalizing it and I'm not sure if it's even defined in the ACP - I doubt) and we simply hardcode the theme as mybb.css - missing stylesheets or minified stylesheets should belong in another issue.

[DiogoParrinha]

Merged yo PR, closing this.