Need load jquery.sceditor.default.min.css to style blockquote in sceditor

[martec]

need load jquery.sceditor.default.min.css to style blockquote etc...

http://i.imgur.com/bLSHIEk.png
i get image above in www.sceditor.com

you can check that minified/themes/default.min.css and minified/jquery.sceditor.default.min.css not are same file.

Quote tag without jquery.sceditor.default.min.css
http://i.imgur.com/JcFmTjl.png

Quote tag with jquery.sceditor.default.min.css
http://i.imgur.com/hZUOtKZ.png

[DiogoParrinha]

Please see:
https://github.com/mybb/mybb/blob/master/CONTRIBUTING.md

This is getting out of hand, we're getting bug reports every day and it's impossible to keep track of them because they have no milestone by default and no labels so we have to go through all issues without milestone, including Pull Requests to check each one.

[martec]

@PirataNervo
I saw now that you assignee this... (thanks)
For me jquery.sceditor.mybb.css (default of plugin of sceditor for mybb 1.6) is better than jquery.sceditor.default.min.css (default of sceditor), because has better style #672.
But i think that more better if we made one new that combine with style of mybb 1.8 as image below:
http://i.imgur.com/gLITrSY.png

[DiogoParrinha]

@martec alright I see the differences. I'm just confused about what's the real issue here? We're not loading something, are we loading two different things? Are we loading something twice?

[martec]

@PirataNervo

We loading something twice {$theme['editortheme']}. (line 1 and line 10 of codebutton template). And not loading something.
Line 10 used to load style of contet of textarea (blockquote, blockcode etc... and not style of theme editor), correct file to load in line 10 is "{$mybb->asset_url}/jscripts/sceditor/jquery.sceditor.default.min.css".

in mybb 1.8 beta codebutton template

<link rel="stylesheet" href="jscripts/sceditor/editor_themes/{$theme['editortheme']}" type="text/css" media="all" />
<link rel="stylesheet" href="jscripts/sceditor/editor_themes/extrabuttons.css" type="text/css" media="all" />
<script type="text/javascript" src="jscripts/sceditor/jquery.sceditor.bbcode.min.js"></script>
<script type="text/javascript" src="jscripts/bbcodes_sceditor.js"></script>
<script type="text/javascript" src="jscripts/sceditor/editor_languages/{$lang->settings['htmllang']}.js"></script>
<script type="text/javascript">
$(function() {
    $("#{$bind}").sceditor({        
        plugins: "bbcode",
        style: "{$mybb->asset_url}/jscripts/sceditor/editor_themes/{$theme['editortheme']}", //(repeat same file of first line)

correct code

<link rel="stylesheet" href="jscripts/sceditor/editor_themes/{$theme['editortheme']}" type="text/css" media="all" />
<link rel="stylesheet" href="jscripts/sceditor/editor_themes/extrabuttons.css" type="text/css" media="all" />
<script type="text/javascript" src="jscripts/sceditor/jquery.sceditor.bbcode.min.js"></script>
<script type="text/javascript" src="jscripts/bbcodes_sceditor.js"></script>
<script type="text/javascript" src="jscripts/sceditor/editor_languages/{$lang->settings['htmllang']}.js"></script>
<script type="text/javascript">
$(function() {
    $("#{$bind}").sceditor({        
        plugins: "bbcode",
        style: "{$mybb->asset_url}/jscripts/sceditor/jquery.sceditor.default.min.css", //(here used to load style of quote, block quote)

[DiogoParrinha]

Yeap I see what you mean, you're correct. Do you have a PR for this? We could definitely style it to match 1.8's blockquote but I don't have time right now, I have an extremely busy week and I'd like to have this fixed and then for Beta 3 we could improve it.

[martec]

@PirataNervo
you can use #672
if don´t want use jquery.sceditor.mybb.css ...
i can made PR with jquery.sceditor.default.min.css in some minutes...

[DiogoParrinha]

@martec i've merged your PR. Are you going to submit a PR to change the style to match 1.8 style? Like suggested here: #667 (comment)

[martec]

@PirataNervo
yes i will...

[DiogoParrinha]

Alright thanks.

[martec]

@PirataNervo
done.

[DiogoParrinha]

Merged, this is now finished. Thank you @martec

[martec]

@PirataNervo
thanks.