Use jquery.sceditor.mybb.css from plugin sceditor for Mybb. And fix too #667 #666 #662 #663 #420 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 31, 2014 21:25
martec
changed the title
martec
changed the title
This was referenced Jun 1, 2014
Closed
|
@martec we only accept one PR per issue otherwise if it doesn't fix A but fixes B and C we cannot accept it. |
|
@PirataNervo |
|
I'll manually fix this issue if you don't submit another PR in the future - I appreciate the fix! |
|
@PirataNervo |
This was referenced Jun 1, 2014
Closed
|
close this because i pull request another that solve problem with commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jquery.sceditor.mybb.css from https://github.com/samclarke/SCEditor-MyBB/tree/master/jscripts/sceditor
Better use jquery.sceditor.mybb.css instead jquery.sceditor.default.min.css has better style for blockquote, blockcode etc..
jquery.sceditor.mybb.css
http://i.imgur.com/V7u7TiE.png
jquery.sceditor.default.min.css
http://i.imgur.com/hZUOtKZ.png
And i don´t recommend use minify file in this case, because this file is used too to put style for pre tag (used in spoiler tag) etc. Simply put this file is often used for customization.
This pull fix too #667 #666 #662 #663 #420 . So case to apply this, does not apply to others.