Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load custom setting at the end #50

Closed
Eldenroot opened this issue Mar 13, 2019 · 0 comments
Closed

Load custom setting at the end #50

Eldenroot opened this issue Mar 13, 2019 · 0 comments
Labels
invalid This doesn't seem right

Comments

@Eldenroot
Copy link
Member

Eldenroot commented Mar 13, 2019 •
edited
Loading

There is an issue with loading custom settings - not possible right now to use slideclass: 'watermark' in mybbfancybox.js - it is not loaded, overloaded by default settings.

This need to be loaded at the end of headerinclude, not in mybbfancybox.js. Maybe the best place would be there: https://github.com/mybbgroup/MyBB_Fancybox/blob/0e165d12e5d8299acba9fd5e6c635af1a352b131/inc/plugins/mybbfancybox.php#L400

https://codepen.io/anon/pen/vPpRjJ
@Eldenroot Eldenroot added bug Something isn't working enhancement New feature or request labels Mar 13, 2019
@Eldenroot Eldenroot added this to the v0.9.0 milestone Mar 15, 2019
@Eldenroot Eldenroot removed bug Something isn't working enhancement New feature or request labels Mar 16, 2019
@Eldenroot Eldenroot removed this from the v0.9.0 milestone Mar 16, 2019
@Eldenroot Eldenroot added the invalid This doesn't seem right label Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eldenroot