Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivation Error #78

Closed
schauan opened this issue Jan 18, 2021 · 3 comments
Closed

Deactivation Error #78

schauan opened this issue Jan 18, 2021 · 3 comments
Milestone
v1.1.1

Comments

@schauan
Copy link

schauan commented Jan 18, 2021

when I deactivate the plugin, it will be shown in the plugin list to "install and activate". Also the entry for settings is shown ...
After reinstall I have the settings two times in my forum (1.8.24, php 7.3.x), one time the setting for per-post-gallery is not shown (is in the remained settings entry after deactivate)
@Eldenroot
Copy link
Member

Did you install for the first time or update from older version?

@lairdshaw

@lairdshaw
Copy link
Contributor

There is a problem in the plugin. When settings are deleted, they are deleted by individual name, and I had added a new setting in PR #71, but not added that setting to the list of settings to be deleted on uninstall.

I don't know whether this is what caused the reported problem, but it needs to be fixed in any case.

lairdshaw added a commit to lairdshaw/FancyBox that referenced this issue Jan 19, 2021
@lairdshaw
Fix mybbgroup#78: deactivation error
04e6935 
The on-install setting added in mybbgroup#71 wasn't correspondingly
deleted in the uninstall routine. Adjusted the deletion
query to use LIKE rather than individual setting names.
@schauan
Copy link
Author

schauan commented Jan 19, 2021

Eldenroot, it was an update of the plugin. I had the 1.0.1 before. But I don't know at the moment whether I had only deactivated it before or deinstalled ...

@Eldenroot Eldenroot added this to the v1.1.1 milestone Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
3 participants
@Eldenroot @lairdshaw @schauan