Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for Enterprise version #133

Open
toopay opened this issue Apr 13, 2018 · 4 comments
Open

Patch for Enterprise version #133

toopay opened this issue Apr 13, 2018 · 4 comments

Comments

@toopay
Copy link

toopay commented Apr 13, 2018

I have tried to integrate this library with 0.11.0.3-enterprise-edition but it thrown an exception, related with semver. If anyone interested, I can dig further and create a PR.
@CyExy
Copy link
Contributor

CyExy commented Apr 13, 2018

Thanks, PR is welcome.

@CyExy
Copy link
Contributor

CyExy commented Apr 13, 2018

Related #129

@toopay
Copy link
Author

toopay commented Apr 20, 2018

Great. I'll submit PR next week. Thanks @CyExy !

@toopay toopay mentioned this issue Apr 23, 2018
Open
@toopay
Copy link
Author

toopay commented Apr 23, 2018

Hey @CyExy I propose #134 as resolution to this issue - as well as promoting the cleanup of customized validation for enterprise edition by fully rely to semver coerce option. Lmk what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CyExy @toopay