-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo limit #9
Comments
Team's ResponseThe undo command works as expected (able to undo commands that alter the AddressBook) and the correct behaviour of the application is observed. What the tester has observed and experienced is the limit set by the undo command (only able to undo up to last 4 commands) and this is similar to how modern applications handles undo for operations (ie there is a fixed amount of commands that the application is able to undo for). In addition, for modern applications (for example, IntelliJ) when the undo limit is hit, the application does not show that "the limit is hit" but instead it just shows that there are no further instructions to undo. This issue should not be considered a High priority as it is unlikely that users would have to undo so many commands at once and should be a Low priority instead as users would still be able to continue using the application without any issues as the undo command still works as intended. The bug type should also be under documentation as a note indicating to the user that there is a limit on how many commands they can undo. Items for the Tester to Verify❓ Issue responseTeam chose [
Reason for disagreement: Thank you for your response. ❓ Issue typeTeam chose [
Reason for disagreement: [replace this with your explanation] ❓ Issue severityTeam chose [
Reason for disagreement: Thank you for your response. The extent of the inconvenience caused in my above point may be arguable, but what I believe is not arguable is that in the present state of your application and its documentation, many users such as myself will be misled into believing there is no undo limit (or at least a very high undo limit) and will almost certainly run into issues because of this. Another way to frame this is that if you were to continue working on this application, you would definitely have to update the documentation to reflect the undo limit, and it would definitely also cross your mind that the undo limit should also be increased if you want to scale the application. Hence, I don't think this issue warrants a low severity. I can however agree that medium severity would be more justifiable as this bug does not render the app unusable. |
Delete all clients then try to undo to get back the same address book
Expected to get default addressbook but only got back 4 clients
The text was updated successfully, but these errors were encountered: