Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unescaped # in web API for choosing voice speaker #35

Open
IFcoltransG opened this issue Feb 14, 2023 · 0 comments
Open

Allow unescaped # in web API for choosing voice speaker #35

IFcoltransG opened this issue Feb 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@IFcoltransG
Copy link

IFcoltransG commented Feb 14, 2023

Using the web server POST API, I found voice key selection a little confusing. I could enter a speakerless key like en_US/vctk_low without escaping the /, which made me think the # in en_US/vctk_low#p238 wouldn't need to be URI encoded as %23 either. I expected the API to parse the fragment and convert it to a speaker. Not so, it simply ignores the fragment, which puzzled me for some time figuring out how to set a speaker.

I would like the API to parse any fragments and append them to the last query with a hash sign. This would make it consistent with not needing to escape the /.

The current workaround is simply to use %23 as an escaped replacement for a hash in POST requests. It makes sense for a web API to require this, but it made my user experience worse due to confusion with the /.
Another aid could be to give an example in the documentation where the curl query has a speaker set, which would include the escaped #.

@IFcoltransG IFcoltransG added the enhancement New feature or request label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant