Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Removal of mycroft-stock from test config wiping default.yml #1544

Closed
krisgesling opened this issue Jul 29, 2021 · 0 comments
Closed

Removal of mycroft-stock from test config wiping default.yml #1544

krisgesling opened this issue Jul 29, 2021 · 0 comments

Comments

@krisgesling
Copy link
Contributor

krisgesling commented Jul 29, 2021

Updated
The attempt to filter out the removed mycroft-stock Skill from the test config is returning a blank file that cannot be iterated over. This is caused by writing to the same file being grepped.

https://hudson.mycroft.team/blue/organizations/jenkins/mycroft-skills/detail/PR-1543/1/pipeline

Step 11/25 : RUN grep --invert-match mycroft-stock default.yml | tee default.yml

 ---> Running in f38f985aa9f3

Removing intermediate container f38f985aa9f3

 ---> 6278c6ac7c68

Step 12/25 : RUN python -m test.integrationtests.voight_kampff.test_setup     --config default.yml     --platform $platform

 ---> Running in 3370a7a7bc03

Traceback (most recent call last):

  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main

    "__main__", mod_spec)

  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code

    exec(code, run_globals)

  File "/opt/mycroft/mycroft-core/test/integrationtests/voight_kampff/test_setup.py", line 233, in <module>

    main(get_arguments(sys.argv[1:]))

  File "/opt/mycroft/mycroft-core/test/integrationtests/voight_kampff/test_setup.py", line 217, in main

    apply_config(args.config, args)

  File "/opt/mycroft/mycroft-core/test/integrationtests/voight_kampff/test_setup.py", line 67, in apply_config

    if not args.test_skills and 'test_skills' in conf_dict:

TypeError: argument of type 'NoneType' is not iterable

The command '/bin/sh -c python -m test.integrationtests.voight_kampff.test_setup     --config default.yml     --platform $platform' returned a non-zero code: 1
@krisgesling krisgesling changed the title Non-Skill based PR's may fail VK test Removal of mycroft-stock from test config wiping default.yml Jul 29, 2021
krisgesling added a commit that referenced this issue Jul 29, 2021
Fix #1544 - remove stock skill from test config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant