Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables accidental reinit on import page buttons #255

Closed
barbequesauce opened this issue Apr 18, 2020 · 5 comments
Closed

Datatables accidental reinit on import page buttons #255

barbequesauce opened this issue Apr 18, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@barbequesauce
Copy link
Collaborator

Discovered by @ajslater

Both the flushImports and markImports?action=massimport buttons at the top are asking the datatable to reload, which is not allowed per https://datatables.net/tn/3. Presumably an upgrade-related item that wasn't found until now.

@barbequesauce
Copy link
Collaborator Author

We good here?

@sebclark
Copy link

sebclark commented May 7, 2020

Issue still exists in current build

@evilhero
Copy link
Collaborator

evilhero commented May 7, 2020

we are aware.

@evilhero evilhero closed this as completed May 7, 2020
@barbequesauce barbequesauce reopened this May 7, 2020
@barbequesauce
Copy link
Collaborator Author

Listen you

@barbequesauce
Copy link
Collaborator Author

I will forget this if I don't write it down -

script.js, function doAjaxCall line 314:

if ( reload == "table") {
    console.log('refresh'); refreshTable();

function refreshTable line 169:

function refreshTable() {
	var url =  $(location).attr('href');
	$("table.display").load(url + " table.display tbody, table.display thead", function() { 
                         // ^^^ this load is the real problem - but how to fix? 
                         //     reload the page?
		initThisPage();
	});
}

Note this seems to account for both button issues...

evilhero added a commit that referenced this issue Jun 1, 2020
- IMP: Adding Carbon theme (#303)

- Moved publisherlogos directory under data directory instead of under specific interface directory name to reduce replication across any additional interfaces.

- Updated logos to reflect carbon theme better, as well as just generally outdated ones for both interfaces.

- IMP: Converted ComicRN, autoProcessComics scripts to Python 3 (#323)

- FIX: fix for ComicVersion being referenced during a comparison when it doesn't exist in the search result

- FIX:(#275) 'of' being removed from filename during parsing

- Removes all attempts to encode the Issue Name (Partially fixes #282 - db conversion is still required to be completed)

- Better check of comlocation being set prior to attempting to create a series directory during a series add / refresh.

- (#275) Series with 'of <number>' in the title would incorrectly parse,

- improved regex to keep square brackets intact during parsing

- date checker will now accept YYYY-MM-00 as a valid date entry

- FIX:(#279) Option to ignore booktype matches for specific series when searching

- FIX: (#183) Added Force Type dropdown to series detail page - can change the Edition/Type of a given series to any of the available options (TPB, One-Shot, Digital, Print).

- When using Force Type option above, if $Type is enabled in Folder Format configuration, will rename existing folder to new Edition/Type as per the Folder Format string, to show the change at the folder-level

- FIX: Ampersands in issuenums (#299)

- FIX: fix for post-processing TPB's during a manual run if the TPB had an issue number with a decimal place

- Fixes #292 - Pushbullet notifs not working

- FIX: update/correct DT spec in import page (#255) (#289)

- home improvements: Volume included if present in series, filterbox working again with new index

- Fixed incorrect DB SQL error trapping errors.

- If $Type was being used, when recreating directory would default to None instead of Print

- Added some fallback to CV image retrieval based on image size

- NZBGet removal of information from logs

- Removed unquoting of DB data from issue details popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants