Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue parsing comics with "of <number>" in the title #275

Closed
Serneum opened this issue May 2, 2020 · 6 comments
Closed

Issue parsing comics with "of <number>" in the title #275

Serneum opened this issue May 2, 2020 · 6 comments
Assignees
@evilhero
Labels
enhancement New feature or request

Comments

@Serneum
Copy link
Contributor

Serneum commented May 2, 2020

Describe the bug
Mylar seems to be struggling with parsing comics that have of <number> in the name of the comic, ex: Night of 1000 Wolves. My assumption is that this is because Mylar has logic to parse out issue numbers like 01 of 04 like I've seen it do in the past.

CarePackage
carepackage.zip

Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Branch / commit: python3-dev/874e5d961a1da4884d6c9e9b262b2a2b4667cfc0

Additional information
Add any other information about the problem here.
@barbequesauce barbequesauce added the enhancement New feature or request label May 6, 2020
@evilhero
Copy link
Collaborator

Yep, you're right that would be problematic and odds are that's exactly what's happening. I'd like to say it's a simple fix, but...well, I won't say that just yet - I have a feeling it might be a bit more involved. I'll take this one to look into more, since I'm pretty sure that @barbequesauce has mentioned in several other instances, that he won't touch the file parser with an elongated 10' pole.

@evilhero evilhero self-assigned this May 21, 2020
evilhero added a commit that referenced this issue May 25, 2020
@evilhero
(#275) Series with 'of <number>' in the title would incorrectly parse…
d5a988e 
…, improved regex to keep square brackets intact during parsing, date checker will now accept YYYY-MM-00 as a valid date entry
@evilhero evilhero mentioned this issue May 25, 2020
Merged
barbequesauce pushed a commit that referenced this issue May 25, 2020
@evilhero @barbequesauce
(#275) Series with 'of <number>' in the title would incorrectly parse…
31976cc 
…, improved regex to keep square brackets intact during parsing, date checker will now accept YYYY-MM-00 as a valid date entry
@barbequesauce
Copy link
Collaborator

@Serneum can you give this a try? The fixes should be in now...

@Serneum
Copy link
Contributor Author

Serneum commented May 26, 2020 •
edited

Not at home so doing this from my phone. I ran a Recheck on the files I had in the directory for the comic and got

FAILED FILES: [{'parse_status': 'failure', 'sub': None, 'comicfilename': 'Night of 1000 Wolves 001 (2013).cbz', 'comiclocation': '/mnt/Comics/Night of 1000 Wolves (2013)', 'series_name': 'Night 1000 Wolves', 'series_volume': None, 'alt_series': None, 'alt_issue': None, 'issue_year': '2013', 'issue_number': '001', 'issueid': None, 'scangroup': None, 'booktype': 'issue'}]

I can set up debugging logging tonight and try again to get more information

It's a TPB so maybe I manually named the file incorrectly. Comic ID is 4050-68833 if that helps

evilhero added a commit that referenced this issue May 28, 2020
@evilhero
FIX:(#275) 'of' being removed from filename during parsing
eec408b
barbequesauce pushed a commit that referenced this issue May 28, 2020
@evilhero @barbequesauce
FIX:(#275) 'of' being removed from filename during parsing
c0213f6
@Serneum
Copy link
Contributor Author

Serneum commented May 28, 2020

Sorry for the delay. I updated again and now it is working. Looks like some new changes were added over the past few hours, so I assume that's where it started working

@barbequesauce
Copy link
Collaborator

great - can we close the issue?

@Serneum
Copy link
Contributor Author

Serneum commented May 29, 2020

Yeah. I wasn't sure if it was okay for me to do so, so I left it open. I'll close it with this comment.

@Serneum Serneum closed this as completed May 29, 2020
@evilhero evilhero mentioned this issue May 31, 2020
Closed
evilhero added a commit that referenced this issue Jun 1, 2020
@evilhero
python3-dev merge
c11530f 
- IMP: Adding Carbon theme (#303)

- Moved publisherlogos directory under data directory instead of under specific interface directory name to reduce replication across any additional interfaces.

- Updated logos to reflect carbon theme better, as well as just generally outdated ones for both interfaces.

- IMP: Converted ComicRN, autoProcessComics scripts to Python 3 (#323)

- FIX: fix for ComicVersion being referenced during a comparison when it doesn't exist in the search result

- FIX:(#275) 'of' being removed from filename during parsing

- Removes all attempts to encode the Issue Name (Partially fixes #282 - db conversion is still required to be completed)

- Better check of comlocation being set prior to attempting to create a series directory during a series add / refresh.

- (#275) Series with 'of <number>' in the title would incorrectly parse,

- improved regex to keep square brackets intact during parsing

- date checker will now accept YYYY-MM-00 as a valid date entry

- FIX:(#279) Option to ignore booktype matches for specific series when searching

- FIX: (#183) Added Force Type dropdown to series detail page - can change the Edition/Type of a given series to any of the available options (TPB, One-Shot, Digital, Print).

- When using Force Type option above, if $Type is enabled in Folder Format configuration, will rename existing folder to new Edition/Type as per the Folder Format string, to show the change at the folder-level

- FIX: Ampersands in issuenums (#299)

- FIX: fix for post-processing TPB's during a manual run if the TPB had an issue number with a decimal place

- Fixes #292 - Pushbullet notifs not working

- FIX: update/correct DT spec in import page (#255) (#289)

- home improvements: Volume included if present in series, filterbox working again with new index

- Fixed incorrect DB SQL error trapping errors.

- If $Type was being used, when recreating directory would default to None instead of Print

- Added some fallback to CV image retrieval based on image size

- NZBGet removal of information from logs

- Removed unquoting of DB data from issue details popup
@Serneum Serneum mentioned this issue Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evilhero evilhero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evilhero @Serneum @barbequesauce